[wp-trac] [WordPress Trac] #47014: Tag balancing corrupts Custom Elements

WordPress Trac noreply at wordpress.org
Sat Jun 1 04:47:29 UTC 2019


#47014: Tag balancing corrupts Custom Elements
--------------------------------------+------------------------
 Reporter:  westonruter               |       Owner:  flixos90
     Type:  defect (bug)              |      Status:  reviewing
 Priority:  normal                    |   Milestone:  5.3
Component:  Formatting                |     Version:  2.0.4
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+------------------------

Comment (by dmsnell):

 @flixos90 for your perusal I also submitted a patch based on your work. in
 it I've taken the expanded tag name rules you provided but then moved the
 parsing logic mostly back into the RegExp. In the process I created a
 series of helper variables to make the logic clearer for me to understand.

 Concerning the other tests I was curious why you removed the checks that
 specifically handled those cases? Did you intend on removing those in your
 patch? the `is_serialized()` test and changes in
 `wp_targeted_link_rel_callback` and such?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47014#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list