[wp-trac] [WordPress Trac] #47498: Revise checkbox/radio button css for better compatibility with text zoom
WordPress Trac
noreply at wordpress.org
Wed Jul 31 15:34:26 UTC 2019
#47498: Revise checkbox/radio button css for better compatibility with text zoom
-------------------------------------------------+-------------------------
Reporter: kjellr | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 5.3
Component: Administration | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-design-feedback | Focuses: ui,
wpcampus-report form-controls color-contrast | accessibility
-------------------------------------------------+-------------------------
Comment (by kjellr):
Excellent improvement, @afercia. Thanks for sorting out the URL encoding.
It makes the code a lot less readable, but at least it works this time
around. I can confirm that this fixes the color for various color schemes
as well. 👍
> if anyone comes up with a better method to replace the hash character #
with the URL-encoded value %23, that would be welcomed!
I can't think of one offhand — trimming that off the string like you're
doing seems okay. I do think it's worth adding an inline comment above
that function to explain what it's for.
Thanks again!
--
Ticket URL: <https://core.trac.wordpress.org/ticket/47498#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list