[wp-trac] [WordPress Trac] #45800: Add short circuits for WP_Comment_Query

WordPress Trac noreply at wordpress.org
Tue Jul 30 20:41:33 UTC 2019


#45800: Add short circuits for WP_Comment_Query
--------------------------------------+------------------------------
 Reporter:  spacedmonkey              |       Owner:  adamsilverstein
     Type:  enhancement               |      Status:  assigned
 Priority:  normal                    |   Milestone:  5.3
Component:  Comments                  |     Version:  3.1
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+------------------------------

Comment (by adamsilverstein):

 @boonebgorges if you have a few moments I would appreciate a code review
 here before committing this change.

 Do you see any issue with exiting early here, leaving counts, caching,
 pagination and `query_args` handling up to the filter users? Anything else
 we should highlight in the docblock or in the eventual Dev note?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45800#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list