[wp-trac] [WordPress Trac] #47607: Add a loader when adding a new category

WordPress Trac noreply at wordpress.org
Fri Jul 26 17:42:34 UTC 2019


#47607: Add a loader when adding a new category
-------------------------------------+-------------------------------------
 Reporter:  guddu1315                |       Owner:  andg
     Type:  enhancement              |      Status:  assigned
 Priority:  normal                   |   Milestone:  5.3
Component:  Taxonomy                 |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch has-           |     Focuses:  ui, accessibility,
  screenshots                        |  administration
-------------------------------------+-------------------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:5 andg]:
 > I have inspected the code in that page, and found out that, actually,
 there ''is'' a spinner element already in the markup. It just has
 `visibility: hidden` by default, and is never shown.

 I could not reproduce that, there's just [source:tags/5.2.2/src/wp-admin
 /edit-tags.php?marks=519#L508 submit_button()] in that place. I had to add
 the spinner element when testing the patch.

 Replying to [ticket:47607 guddu1315]:
 > So when it takes 5-10 seconds user gets frustrated and clicks on add new
 category again and then category is added twice.

 I also could not reproduce that. I do see multiple requests in browser
 tools' Network tab, however they result in appropriate error messages
 instead of duplicate categories:
 * `A term with the name provided already exists with this parent.` for
 categories.
 * `A term with the name provided already exists in this taxonomy.` for
 tags.

 Still, avoiding those multiple requests seems good :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47607#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list