[wp-trac] [WordPress Trac] #47783: PHP 7.4: Deprecations

[WordPress Trac]

#47783: PHP 7.4: Deprecations
--------------------------+------------------------------
 Reporter:  ayeshrajans   |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  General       |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+------------------------------

Comment (by ayeshrajans):

 PHP 7.4 deprecates `get_magic_quotes_gpc` and `get_magic_quotes_runtime`.
 This was long due, and there are few issues in Trac about removing this
 functionality. Historically, those bits were there because we supported
 PHP 5.2-5.4, when magic quotes were being used in the wild.

 With WordPress no longer supporting PHP versions < 5.6, we can now remove
 these checks completely.

 There are 3 patches following this comment:




 **1. Fixes in WordPress core:** 47783-magic_quotes_deprecation-wp-
 core.patch

 This fixes all magic quote calls in core.


 **2. Fixes in external libs: Getid3:** 47783-magic_quotes_deprecation-
 getid3.patch

 This has come up in other tickets, and I think we can follow the same
 conclusion in other tickets whether we maintain our fork, or try to push
 upstream to update.


 **3. Fixes in external libs: PHPMaier:** 47783-magic_quotes_deprecation-
 phpmailer.patch

 PHPMailer is an active project, so I opened a PR
 https://github.com/PHPMailer/PHPMailer/pull/1794 with the same patch. We
 are using v5.2.2, although latest version is 5.2.7 in upstream.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47783#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform