[wp-trac] [WordPress Trac] #47772: Too few arguments: class-bulk-upgrader-skin.php

[WordPress Trac]

#47772: Too few arguments: class-bulk-upgrader-skin.php
------------------------------+----------------------
 Reporter:  subrataemfluence  |       Owner:  (none)
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:
Component:  Plugins           |     Version:  5.2.2
 Severity:  normal            |  Resolution:  invalid
 Keywords:                    |     Focuses:
------------------------------+----------------------
Changes (by SergeyBiryukov):

 * status:  new => closed
 * resolution:   => invalid
 * milestone:  Awaiting Review =>


Comment:

 Hi @subrataemfluence, thanks for the ticket!

 Looking at the similar [https://wordpress.org/support/topic/sprintf-too-
 few-arguments-2/ support forums report], this appears to be an issue with
 some plugins and themes using an older version of
 [https://github.com/TGMPA/TGM-Plugin-Activation TGM Plugin Activation]
 library, which doesn't account for the changes in [40646].

 Before [40646], `$this->upgrader->strings['skin_update_successful']` used
 to contain two string placeholders and the subsequent `sprintf()` call had
 two parameters. Now it only has one.

 TGM Plugin Activation [https://github.com/TGMPA/TGM-Plugin-
 Activation/commit/0fa103aacd5d1ee85a9a26dc61de5e45e05b215c fixed this two
 years ago], however plugins or themes using an older version would still
 display the warning. FWIW, the Newsletter plugin doesn't seem to be the
 culprit here, I couldn't reproduce the issue after installing it. Looking
 at the [https://wordpress.org/plugins/newsletter/#developers changelog],
 the plugin did use the TGMPA library at some point, but it was removed in
 version 4.7.9, and the current version is 6.1.2. The issue might be in one
 of the other plugins or the theme you're using.

 Going to close the ticket, as it's not a WordPress core issue.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47772#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform