[wp-trac] [WordPress Trac] #44038: Change personal data export path stored in request meta to relative paths

WordPress Trac noreply at wordpress.org
Wed Jul 24 17:44:37 UTC 2019


#44038: Change personal data export path stored in request meta to relative paths
-------------------------------------------------+-------------------------
 Reporter:  allendav                             |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  5.3
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  needs-unit-tests has-patch needs-    |     Focuses:
  refresh good-first-bug                         |  administration
-------------------------------------------------+-------------------------

Comment (by nmenescardi):

 I’ve been reviewing this ticket. I applied last patch (44038.2) and ran
 existing tests in privacy group, they all passed.

 Also, I created two more tests related with this ticket using absolute
 paths. I tried to follow some of the points highlighted on @desrosj
 comment: https://core.trac.wordpress.org/ticket/44038#comment:12

 I found two possible issues with this patch:
 1) if a not valid path is saved (eg: change hosting) I believe it doesn’t
 resolve a new valid directory and file name.

 2) If an old valid absolute path was saved, it doesn’t keep that value.
 Instead, it generates and saves a relative path as new value. It works
 with new links but probably it doesn’t preserve old ones.

 Tests are added in a new patch: 44038.3 along with previous changes.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44038#comment:25>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list