[wp-trac] [WordPress Trac] #46312: Replace http with https in custom links menu item
WordPress Trac
noreply at wordpress.org
Wed Jul 24 07:21:43 UTC 2019
#46312: Replace http with https in custom links menu item
----------------------------------------------+-----------------------
Reporter: aksl95 | Owner: audrasjb
Type: enhancement | Status: accepted
Priority: normal | Milestone: 5.3
Component: Menus | Version:
Severity: normal | Resolution:
Keywords: has-screenshots has-patch commit | Focuses:
----------------------------------------------+-----------------------
Changes (by audrasjb):
* keywords: has-screenshots has-patch needs-testing => has-screenshots
has-patch commit
Comment:
Replying to [comment:22 aksl95]:
> Replying to [comment:21 jorbin]:
> > I wonder if rather than defaulting to https, it might make sense to
default to whatever protocol the site is set to use in `home`.
>
> For custom links, I don't know if it has a relationship because these
links can be external.
Agree. There is no relationship with the website protocol since custom
links are used for both internal and external link.
Also, the patch is tested and still applies cleanly on my side. Adding
`commit` keyword.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46312#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list