[wp-trac] [WordPress Trac] #47746: PHP 7.4 compatibility fix / implode argument order

[WordPress Trac]

#47746: PHP 7.4 compatibility fix / implode argument order
--------------------------+-------------------------------
 Reporter:  jrf           |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  5.3
Component:  General       |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  coding-standards
--------------------------+-------------------------------

Comment (by jrf):

 Replying to [comment:2 johnbillion]:
 > The changes to Requests and Simplepie need to be made upstream to their
 respective repos.
 >
 > The other two changes look good.

 Pull requests to both upstream repos have already been opened (see links
 above), but neither is very actively maintained.

 The `Requests` dependency in Core is at the latest version - `1.7` -, but
 that version was released in October 2016 (!!!).
 Ref: https://github.com/rmccue/Requests/releases

 The `Requests` repo has had no commits since December 2017 and only a few,
 mostly DevOps related ones since the last release.


 The `SimplePie` dependency in Core is at version `1.3.1` - which was
 released in October 2012 😰, while the current version is `1.5.2` released
 in August 2018.
 Ref: https://github.com/simplepie/simplepie/releases


 And while the `SimplePie` repo has actually had some commits this year
 (February), the version used in WP Core is pretty far behind the latest
 release.

 So, yes, while I agree that the fixes should primarily be made upstream, I
 don't think WP should be throwing deprecation notices when run on PHP 7.4
 while we are waiting for
 1) new releases from upstream and
 2) the existing WP Core versions of those libraries to be updated.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47746#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform