[wp-trac] [WordPress Trac] #46227: Add Rel-Feed Link to Header

[WordPress Trac]

#46227: Add Rel-Feed Link to Header
-------------------------------------------------+-------------------------
 Reporter:  dshanske                             |       Owner:  (none)
     Type:  enhancement                          |      Status:  reopened
 Priority:  low                                  |   Milestone:  5.3
Component:  Feeds                                |     Version:
 Severity:  trivial                              |  Resolution:
 Keywords:  has-patch has-unit-tests dev-        |     Focuses:
  feedback needs-testing 2nd-opinion reporter-   |
  feedback                                       |
-------------------------------------------------+-------------------------
Changes (by garrett-eclipse):

 * keywords:  has-patch has-unit-tests dev-feedback needs-testing =>
     has-patch has-unit-tests dev-feedback needs-testing 2nd-opinion
     reporter-feedback
 * milestone:  5.2.3 => 5.3


Comment:

 Hello All, Thank you for the patches to date on this.

 I took a moment to read through the reference material
 (https://blog.whatwg.org/feed-autodiscovery) and feel we're going in the
 wrong direction here.

 The 'feed' relationship is to indicate that the reference document is a
 syndication feed NOT a page.
 "we have introduced a new feed relationship which indicates that the
 referenced document is a syndication feed. This now allows you to link to
 several different feeds containing different content which are not
 necessarily alternate versions of the page."

 In WP feed <link>'s are introduced in several places with the `alternate`
 relationship attribute in many cases the issue with them is that they
 aren't 'necessarily alternate representations of the page' which is where
 the `feed` relationship comes in as it 'allows you to link to several
 different feeds containing different content which are not necessarily
 alternate versions of the page.'

 "The feed keyword can also be used in combination with alternate to say
 that it is specifically the feed for the current document."

 So to my understanding the existing feed <link>s should be updated to use
 'rel="feed"' with the exception of the blog page itself which should use
 'rel="feed alternate"' as the feed is actually an `alternate`
 representation of the page.

 The existing locations which should be looked at;
 Ones I feel should just be 'rel="feed"' unless they reside on the blog
 page;
 - Blog RSS - https://github.com/WordPress/WordPress/blob/master/wp-
 includes/feed-atom-comments.php#L57
 - Feed Link - https://github.com/WordPress/WordPress/blob/master/wp-
 includes/general-template.php#L2835
 - Comment Feed Link - https://github.com/WordPress/WordPress/blob/master
 /wp-includes/general-template.php#L2846
 - Multi-Feed Link - https://github.com/WordPress/WordPress/blob/master/wp-
 includes/general-template.php#L2932
 Ones I feel should be 'rel="feed alternate"';
 - Comment Feed - https://github.com/WordPress/WordPress/blob/master/wp-
 includes/feed-atom-comments.php#L49
 - Search Feed - https://github.com/WordPress/WordPress/blob/master/wp-
 includes/feed-atom-comments.php#L53
 - Comment Link - https://github.com/WordPress/WordPress/blob/master/wp-
 includes/feed-atom-comments.php#L91
 - Atom Feed Link - https://github.com/WordPress/WordPress/blob/master/wp-
 includes/feed-atom.php#L35
 - Atom Feed Link - https://github.com/WordPress/WordPress/blob/master/wp-
 includes/feed-atom.php#L67

 In no way am I a RSS/Atom Guru so would love some insight from a more
 experienced dev, @dshanske any thoughts?
 *I very well may be wrong in which case sorry for the scare.

 As well this is an enhancement and not a bug so shouldn't be on a minor
 milestone as it's not a reversion introduced in 5.2 so moving into 5.3 for
 further discussion.

 I apologize to those who already submitted a patch as I had done, I should
 have delved deeper initially.

 *Note: All quoted text comes from the reference material -
 https://blog.whatwg.org/feed-autodiscovery

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46227#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform