[wp-trac] [WordPress Trac] #47632: Coding Standards fixes for WP 5.3

WordPress Trac noreply at wordpress.org
Fri Jul 19 07:47:25 UTC 2019


#47632: Coding Standards fixes for WP 5.3
----------------------------+-------------------------------
 Reporter:  pento           |       Owner:  pento
     Type:  task (blessed)  |      Status:  assigned
 Priority:  normal          |   Milestone:  5.3
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:  coding-standards
----------------------------+-------------------------------

Comment (by pento):

 In [changeset:"45665" 45665]:
 {{{
 #!CommitTicketReference repository="" revision="45665"
 Coding Standards: Move the remaining PHPCS errors to report as warnings,
 and add Travis tests.

 The remaining error-level coding standards issues (specifically,
 associated with the sniffs `WordPress.PHP.YodaConditions.NotYoda`,
 `WordPress.NamingConventions.ValidVariableName.VariableNotSnakeCase`,
 `WordPress.DB.PreparedSQL.InterpolatedNotPrepared`,
 `WordPress.DB.PreparedSQL.NotPrepared`, and
 `WordPress.Files.FileName.InvalidClassFileName`) are marked as warnings,
 until they're all addressed.

 This change allows us to run linting on Travis across the entire codebase,
 ensuring no other error-level violations can be introduced.

 Additionally, PHPCS will now cache results locally, drastically improving
 performance for subsequent checks: scanning the entire codebase takes 1-2
 minutes the first time, and less than one second for subsequent checks.

 See #47632.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47632#comment:40>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list