[wp-trac] [WordPress Trac] #46750: Twenty Nineteen: Add styles to support the group block

[WordPress Trac]

#46750: Twenty Nineteen: Add styles to support the group block
---------------------------------------+----------------------------
 Reporter:  kjellr                     |       Owner:  laurelfulford
     Type:  enhancement                |      Status:  closed
 Priority:  normal                     |   Milestone:  5.3
Component:  Bundled Theme              |     Version:
 Severity:  normal                     |  Resolution:  fixed
 Keywords:  has-patch has-screenshots  |     Focuses:
---------------------------------------+----------------------------

Comment (by razvanonofrei):

 Hello there,

 I'm a little late to the party, but just wanted to chime in and give my
 two cents on this and also hear what you think about it.

 My main concern is related to the fact that having a full width container
 with some inner blocks that should keep the content width of the blocks
 outside the container is going to become a popular pattern soon, but
 keeping plugins and themes compatible is already pretty touch.

 For example, the core Cover Block does pretty much the same thing as the
 Group Block (speaking in terms of layout), but the way they are styled
 with CSS is totally different: the cover uses padding while group uses
 margin to center its content.

 Wouldn't it be more useful to make use of the ''already established''
 class naming convention {{{ wp-block-*__inner-container }}} and use less
 specific CSS selectors like {{{ [class*="wp-block"] > [class*="__inner-
 container"] }}}

 This would allow less CSS in some situations but would also allow
 developers to build blocks that would seemingly integrate with Twenty
 Nineteen. I believe that in doing so we would give a chance to having more
 consistency and compatibility across the most popular themes and plugins
 out there. What do you think?

 Best regards,
 Razvan

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46750#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform