[wp-trac] [WordPress Trac] #47711: noindex, wp_die and admin-ajax.php

[WordPress Trac]

#47711: noindex, wp_die and admin-ajax.php
-------------------------------------+-------------------------------------
 Reporter:  harryfear                |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  5.3
Component:  Administration           |     Version:  3.4
 Severity:  normal                   |  Resolution:
 Keywords:  good-first-bug has-      |     Focuses:  administration, rest-
  patch needs-refresh                |  api
-------------------------------------+-------------------------------------
Changes (by garrett-eclipse):

 * keywords:  good-first-bug has-patch => good-first-bug has-patch needs-
     refresh


Comment:

 Hi @robi-bobi

 There's some great assistance here -
 https://make.wordpress.org/core/handbook/tutorials/working-with-
 patches/#creating-a-patch-with-the-command-line

 I followed that when I started. And one of the things I learned when doing
 a patch from SVN is to either specify the file or the folder, in my case I
 just always run svn diff on the src folder;
 `svn diff src > #####.diff`

 You'll want to create the patch file before running the upload_patch
 command. And I assume it picked up that file as you weren't specific as to
 what folder (`src`) to diff.

 In your case I suggest the following commands in this order;
 `svn diff src > 47711.2.diff`
 `grunt upload_patch:47711`
 *The only time I personally don't focus my diff on `src` is when there's
 unit tests and then I include the tests folder like;
 `svn diff src tests > #####.diff`

 Hope that helps,
 P.S. Another tip that took me a while to realize is if your patch
 introduces new files you first have to do an svn add before creating the
 patch file;
 `svn add src/path/to/file.txt`

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47711#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform