[wp-trac] [WordPress Trac] #40030: Pass User and Comment Objects to rest_get_avatar_urls

WordPress Trac noreply at wordpress.org
Sun Jul 14 14:06:48 UTC 2019


#40030: Pass User and Comment Objects to rest_get_avatar_urls
--------------------------------------+-----------------------------
 Reporter:  dshanske                  |       Owner:  (none)
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  Future Release
Component:  REST API                  |     Version:  4.7
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:
--------------------------------------+-----------------------------
Changes (by pputzer):

 * keywords:  needs-patch good-first-bug => good-first-bug has-patch


Comment:

 @donmhico's patch looks good to me, except that I think the parameter
 object should not be referred to as "the Gravatar". I know that's the
 wording from `get_avatar_url()`, but I think "The object to retrieve an
 avatar URL for." would be better to make it clear what the parameter
 actually is. (The suggested wording would also not reinforce the erroneous
 conception that "avatar" and "Gravatar" are interchangeable.)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/40030#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list