[wp-trac] [WordPress Trac] #47321: Show different fatal error message when in Recovery Mode and unable to redirect

[WordPress Trac]

#47321: Show different fatal error message when in Recovery Mode and unable to
redirect
-------------------------------------------------+-------------------------
 Reporter:  TimothyBlynJacobs                    |       Owner:  marybaum
     Type:  enhancement                          |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.3
Component:  Site Health                          |     Version:  5.2
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch servehappy needs-copy-     |     Focuses:
  review dev-feedback needs-unit-tests           |
-------------------------------------------------+-------------------------
Changes (by garrett-eclipse):

 * keywords:  has-patch servehappy has-copy-review needs-refresh => has-
     patch servehappy needs-copy-review dev-feedback needs-unit-tests


Comment:

 Replying to [comment:26 garrett-eclipse]:
 > After discussing in #core-site-health here -
 https://wordpress.slack.com/archives/CKSU841L7/p1562699059112200
 >
 > The decision was;
 > “There has been a critical error on your website, putting it in recovery
 mode. Please check the Themes and Plugins pages for more details. If you
 just now installed a new Theme or Plugin, check the relevant page for that
 first.”

 I've updated the verbiage according to the Slack discussion mentioned
 above in
 [https://core.trac.wordpress.org/attachment/ticket/47321/47321.4.diff
 47321.4.diff].

 Aside from the verbiage the outstanding questions were;
 Original comment by [comment:12 garrett-eclipse]:
 > Also should the two other strings found in the
 `display_default_error_template` function get some copy love as well to
 match the tone and conveyance of this string? They are;
 > {{{#!php
 > } elseif ( is_protected_endpoint() ) {
 >       $message = __( 'The site is experiencing technical difficulties.
 Please check your site admin email inbox for instructions.' );
 > } else {
 >       $message = __( 'The site is experiencing technical difficulties.'
 );
 > }
 > }}}
 >
 > Also adding 'needs-unit-tests' to account for @afragen's request;
 > `Adding a simple test case for triggering these errors and testing the
 patch would be very helpful.`
 *Added `dev-feedback`, `needs-copy-review` and `needs-unit-tests` to
 address these items.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47321#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform