[wp-trac] [WordPress Trac] #47644: Improve wording for PHP update warning in Site Health

[WordPress Trac]

#47644: Improve wording for PHP update warning in Site Health
-----------------------------------+---------------------
 Reporter:  danieltj               |       Owner:  (none)
     Type:  enhancement            |      Status:  new
 Priority:  normal                 |   Milestone:  5.3
Component:  Site Health            |     Version:  5.2
 Severity:  minor                  |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:
-----------------------------------+---------------------
Changes (by garrett-eclipse):

 * keywords:  needs-patch => has-patch 2nd-opinion


Comment:

 Thanks @danieltj this is great. I see them being much more useful with the
 version clear and available even when unexpanded.

 In [https://core.trac.wordpress.org/attachment/ticket/47644/47644.3.diff
 47644.3.diff] I've made the following additions;
 - Translator comments;
 Line 653 - // translators: %s: The minimum recommended PHP version
 Line 676 - // translators: %s: The server PHP version.
 Line 687 - // translators: %s: The server PHP version.
 *This also caused the sprintf functions there to become multi-line.
 - Verbiage in description was updated for clarity as the value is the
 `recommended_version` and not the latest version (as there's more recent
 minors).
 I went with - `The minimum recommended version of PHP is %s.`
 *Used `minimum recommended` verbiage over just `recommended` as I would
 assume the most recent minor (7.3.7) would really be the recommendation
 but we're using the most recent major (7.3).


 Replying to [comment:12 danieltj]:
 > I took it upon myself to merge the `is_supported` and `is_secure`
 recommended checks together because to me they didn't seem to serve much
 of a purpose as 7.2.x and 7.1.x are both out of date PHP version but also
 both supported anyway so it made little sense to have a slightly different
 wording for something that is basically the same.
 >
 > Saves translators doing an additional string. Sorry for so many replies
 at once!

 I've also supplied
 [https://core.trac.wordpress.org/attachment/ticket/47644/47644.3.revert-
 is_secure.diff 47644.3.revert-is_secure.diff] as I feel there's a large
 difference between `is_supported` and `is_secure` and although it may seem
 slight the difference between the `should` and `recommend` verbiage is
 important.
 https://www.php.net/supported-versions.php
 Referring to the support matrix for PHP;
 > Active support (is_supported) - A release that is being actively
 supported. Reported bugs and security issues are fixed and regular point
 releases are made.
 > Security fixes only (is_secure) - A release that is supported for
 critical security issues only. Releases are only made on an as-needed
 basis.
 Many government bodies and large companies have a policy of stability in
 software and stay on the active support versions but don't upgrade to the
 latest. For these users and many others they `should` upgrade when their
 version drops from active support (`is_supported`) to security fixes
 (`is_secure`), but when they are on an actively supported version while
 it's `recommended` they upgrade in many cases they probably shouldn't due
 to their policies.
 **Note: The reversion patch also has the translator comments and verbiage
 change.

 Happy to discuss that point further.

 Again, thanks for the patch @danieltj marked for testing and a 2nd-opinion
 on the above.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47644#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform