[wp-trac] [WordPress Trac] #47651: Provide required PHP version for plugins with minimum PHP requirement
WordPress Trac
noreply at wordpress.org
Fri Jul 5 20:55:12 UTC 2019
#47651: Provide required PHP version for plugins with minimum PHP requirement
-------------------------------------------------+-------------------------
Reporter: garrett-eclipse | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting
| Review
Component: Site Health | Version: 5.2
Severity: normal | Resolution:
Keywords: has-patch dev-feedback needs- | Focuses:
testing | administration
-------------------------------------------------+-------------------------
Changes (by garrett-eclipse):
* keywords: => has-patch dev-feedback needs-testing
Comment:
Thanks @joyously / @afragen / @justinahinon
I've uploaded
[https://core.trac.wordpress.org/attachment/ticket/47651/47651.diff
47651.diff] to update the verbiage and provide the required PHP version,
see screenshot.
The verbiage used - `This update doesn’t work with your version of
PHP. It requires a minimum of PHP %s.`
*I dropped 'current' as it's implied when stating 'your version'.
Also I moved the translator comment for the Learn more link into it's
sprintf block. But I'm wondering if the two strings for this should be
merged into one. Currently 'Learn more about updating PHP' is separate and
appended so I wonder for i18N if that'll be an issue for RTL languages and
should be one large sprintf string?
Please test
--
Ticket URL: <https://core.trac.wordpress.org/ticket/47651#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list