[wp-trac] [WordPress Trac] #43974: Both personal data request processes should follow the same convention

[WordPress Trac]

#43974: Both personal data request processes should follow the same convention
-------------------------------------------------+-------------------------
 Reporter:  garrett-eclipse                      |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  5.3
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing needs-copy-  |     Focuses:
  review                                         |  administration
-------------------------------------------------+-------------------------

Comment (by garrett-eclipse):

 Thanks @marybaum I appreciate the feedback.

 Sadly the email isn't readily available at the time of the string
 construction as it's localized before the javascript is loaded and then
 used in response to the email action. The email could be appended to the
 end in the javascript but this would break RTL language localizations.

 I also see what you're saying with the 'Success!' being more energetic but
 am wondering if that's needed as it's already in a success notice. We
 could even do without the word completely.

 The other strings we're trying to be consistent with here use 'the
 personal data' and 'for this user' such as the relevant one we're trying
 to match for Erasure;
 `'foundAndRemoved' => __( 'All of the personal data found for this user
 was erased.' ),`

 With that in mind I've added
 [https://core.trac.wordpress.org/attachment/ticket/43974/43974.3.diff
 43974.3.diff] which goes with;
 `'emailSent'       => __( 'The personal data export link for this user was
 sent.' ),`
 *By saying 'sent' it already indicates success, that and it's in a success
 notice.

 Appreciate your thoughts @birgire / @marybaum / @Kerfred

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43974#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform