[wp-trac] [WordPress Trac] #47645: get_theme_mod sprint_f issue

WordPress Trac noreply at wordpress.org
Wed Jul 3 16:50:57 UTC 2019


#47645: get_theme_mod sprint_f issue
----------------------------------------+------------------------------
 Reporter:  katielgc                    |       Owner:  (none)
     Type:  defect (bug)                |      Status:  new
 Priority:  normal                      |   Milestone:  Awaiting Review
Component:  Themes                      |     Version:  5.2.2
 Severity:  major                       |  Resolution:
 Keywords:  needs-patch good-first-bug  |     Focuses:
----------------------------------------+------------------------------
Changes (by davidbaumwald):

 * keywords:  needs-patch => needs-patch good-first-bug


Comment:

 @joyously Good point.  However, even if theme mods are purely
 presentational, this might also happen for fields used for something like
 percentage-based widths.  A possible fix, if deemed necessary, is to
 escape any `%` characters before a `$default` string is passed to the
 `sprintf` call in `get_theme_mod`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47645#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list