[wp-trac] [WordPress Trac] #46073: Off by one error in Imagick testsuite

[WordPress Trac]

#46073: Off by one error in Imagick testsuite
--------------------------+-----------------------------
 Reporter:  Fuegas        |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Future Release
Component:  Media         |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+-----------------------------
Changes (by mikeschroder):

 * milestone:  Awaiting Review => Future Release


Comment:

 I agree your logic is sound here, and we should change it. I prefer the
 option of using the exact corners.

 Right now, it's passing for me locally both before and after the patch,
 which is a bit confusing.

 The next step for me is that I think it'd be helpful to have an image
 where it's more clear what's happening -- thinking a square with a single
 pixel in the corner that is another color, for instance. I'm not sure if
 that'll be exact enough in JPG, but it'd help both with troubleshooting
 the test and having it fail properly in the future if it is.

 If you get a chance to make the image first, feel free. If not, this is on
 my list, since I'd love to figure this out and see it passing properly.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46073#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform