[wp-trac] [WordPress Trac] #43076: current-menu-item for archive menu item on singular page

[WordPress Trac]

#43076: current-menu-item for archive menu item on singular page
-----------------------------------------+------------------------------
 Reporter:  sebastian.pisula             |       Owner:  audrasjb
     Type:  defect (bug)                 |      Status:  reviewing
 Priority:  normal                       |   Milestone:  Awaiting Review
Component:  Menus                        |     Version:
 Severity:  normal                       |  Resolution:
 Keywords:  has-patch reporter-feedback  |     Focuses:
-----------------------------------------+------------------------------
Changes (by audrasjb):

 * keywords:  has-patch => has-patch reporter-feedback
 * owner:  (none) => audrasjb
 * status:  new => reviewing


Comment:

 Hi and thanks for the ticket and you patch,

 I think the patch will need some refresh and some correction to fit better
 with WPCS. However, I'm not sure it's 100% relevant to add `current-menu-
 item` class to archive page when we are in a singular Post: the Post can
 appear in different taxonomy terms and the post can also appear in the
 menu items.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43076#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform