[wp-trac] [WordPress Trac] #46098: Help notice displayed on Privacy Policy page missing in block editor
WordPress Trac
noreply at wordpress.org
Mon Jan 28 19:02:00 UTC 2019
#46098: Help notice displayed on Privacy Policy page missing in block editor
-------------------------------------+-----------------------------
Reporter: aduth | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Future Release
Component: Privacy | Version: 5.0
Severity: normal | Resolution:
Keywords: has-patch needs-refresh | Focuses: administration
-------------------------------------+-----------------------------
Comment (by aduth):
Thanks for the great feedback @garrett-eclipse !
>*These issues may apply in general to the notices module, as you wrote it
I assume you'd know better than I ;)
I think you'd be correct here, though I specifically recall several
iterations back and forth with @joen in the initial implementation toward
a few of these points (mobile specifically). I'd be curious if there's
either been a regression or a mistake in the port to core.
>As the dismiss isn't persistent in that a reload will revive the notice
we should remove the dismiss from this notice and address it along w/ the
dismissal for the classic editor version in #44981.
Yeah, I agree. I think it should also be a feature built-in to the notices
module, and could probably leverage existing persistence functionality
offered to data stores (of which notices extends) via the data persistence
plugin.
https://github.com/WordPress/gutenberg/tree/master/packages/data/src/plugins/persistence
>I noticed this patch removes support of the notice when Classic Editor is
enabled. We should continue providing the notice on the classic editor
interface until at least official support for the classic editor ends.
Yeah, I wasn't sure what to do about this one, whether it ought to remain
as-is or perhaps shift to be implemented specifically as part of the
Classic Editor plugin.
>Looking at the code, the switch to block editor notices also stripped the
translator comment. This should be preserved, and if we have to implement
two versions of the notice to reduce i18N we should stick with one string
w/ translator comments. As the block editor notice supports the link
string it should also get a unique translator comment and I suggest it be
updated to 'View Privacy Policy Guide' to be explicit.
The problem here was that the notices module specifically ''does not''
support arbitrary markup in message texts†, including things like links.
This needs to be enhanced in the notices module, perhaps as part of a
general effort around allowing markup within translated texts for
JavaScript strings.
https://github.com/WordPress/gutenberg/issues/9846
† Technically it does offer support through the `__unstableHTML` property,
but it's been repeatedly mentioned (even as recently as
[https://wordpress.slack.com/archives/C02QB2JS7/p1548255146244100 last
week's editor meeting]) that it's not something which is intended as a
long-term solution.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46098#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list