[wp-trac] [WordPress Trac] #41450: sanitize_text_field() assumes the field is a string

[WordPress Trac]

#41450: sanitize_text_field() assumes the field is a string
------------------------------------+-----------------------
 Reporter:  johnbillion             |       Owner:  pento
     Type:  defect (bug)            |      Status:  reopened
 Priority:  low                     |   Milestone:  5.1
Component:  Formatting              |     Version:  2.9
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:
------------------------------------+-----------------------

Comment (by jadpm):

 Yes, I mean passing a true boolean.

 I am not against strong typing, and I do agree that a function to sanitize
 a string should get a string as source, but I know this function is used
 to sanitize wild data posted by forms on AJAXed and non AJAXes
 environments, to save settings, and gets data from text inputs as well as
 booleans on checkbox fields checked status.

 And of course I think such a change so late in a besta stage has the
 potential of afecting several third parties.

 Anyway, we are adjusting our codebase in case this does not get reverted
 or reviewed.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/41450#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform