[wp-trac] [WordPress Trac] #46112: Use label_count for requests status view links
WordPress Trac
noreply at wordpress.org
Mon Jan 28 06:11:04 UTC 2019
#46112: Use label_count for requests status view links
-------------------------------+---------------------
Reporter: tobifjellner | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 5.1
Component: Posts, Post Types | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
-------------------------------+---------------------
Comment (by garrett-eclipse):
Thanks @ocean90 that cleans it up greatly and applies cleanly. Looks good
in my tests.
I took a look at the origin of the format and it was copied from one of
these two places in core;
class-wp-users-list-table.php -
https://github.com/WordPress/WordPress/blob/master/wp-admin/includes
/class-wp-users-list-table.php#L197 [[BR]]
class-wp-ms-users-list-table.php -
https://github.com/WordPress/WordPress/blob/master/wp-admin/includes
/class-wp-ms-users-list-table.php#L142 [[BR]]
*Both instances on `$role_links['all']` and missing translators comments.
Should they also be adjusted via this ticket? Or shall I split the above
cases into a unique ticket?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46112#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list