[wp-trac] [WordPress Trac] #46111: Admin: Translators comments not in sync in update-core.php

[WordPress Trac]

#46111: Admin: Translators comments not in sync in update-core.php
-----------------------------+-------------------------
 Reporter:  tobifjellner     |       Owner:  swissspidy
     Type:  defect (bug)     |      Status:  assigned
 Priority:  normal           |   Milestone:  5.1
Component:  Upgrade/Install  |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:  needs-patch      |     Focuses:
-----------------------------+-------------------------
Changes (by afercia):

 * status:  new => assigned
 * component:  Administration => Upgrade/Install
 * owner:  (none) => swissspidy
 * milestone:  Awaiting Review => 5.1
 * keywords:   => needs-patch


Old description:

> Several strings in wp-admin/update-core.php for version 5.1 have
> different number of variables than the corresponding string. Here are a
> few examples:
>
> https://build.trac.wordpress.org/browser/trunk/wp-admin/update-
> core.php?marks=83-84#L83
>
> {{{/* translators: 1: URL to WordPress release notes, 1: WordPress
> version number, 2: Minimum required PHP version number, 3: Current PHP
> version number */
> $message = sprintf( __( 'You cannot update because <a
> href="%1$s">WordPress %2$s</a> requires PHP version %3$s or higher. You
> are running version %4$s.' ), $version_url, $update->current,
> $update->php_version, $php_version );}}}
>
> https://build.trac.wordpress.org/browser/trunk/wp-
> admin/upgrade.php?marks=93-94#L93
>
> {{{/* translators: 1: URL to WordPress release notes, 1: WordPress
> version number, 2: Minimum required PHP version number, 3: Current PHP
> version number */
> $message = sprintf( __( 'You cannot update because <a
> href="%1$s">WordPress %2$s</a> requires PHP version %3$s or higher. You
> are running version %4$s.' ), $version_url, $wp_version,
> $required_php_version, $php_version );}}}
>
> https://build.trac.wordpress.org/browser/trunk/wp-admin/update-
> core.php?marks=86-87#L86
>
> {{{/* translators: 1: WordPress version number, 2: Minimum required MySQL
> version number, 3: Current MySQL version number */
> $message = sprintf( __( 'You cannot update because <a
> href="%1$s">WordPress %2$s</a> requires MySQL version %3$s or higher. You
> are running version %4$s.' ), $version_url, $update->current,
> $update->mysql_version, $mysql_version );}}}
>

> https://build.trac.wordpress.org/browser/trunk/wp-
> admin/upgrade.php?marks=96-97#L96
>
> {{{/* translators: 1: WordPress version number, 2: Minimum required MySQL
> version number, 3: Current MySQL version number */
> $message = sprintf( __( 'You cannot update because <a
> href="%1$s">WordPress %2$s</a> requires MySQL version %3$s or higher. You
> are running version %4$s.' ), $version_url, $wp_version,
> $required_mysql_version, $mysql_version );}}}

New description:

 Several strings in wp-admin/update-core.php for version 5.1 have different
 number of variables than the corresponding string. Here are a few
 examples:

 https://build.trac.wordpress.org/browser/trunk/wp-admin/update-
 core.php?marks=83-84#L83

 {{{
 /* translators: 1: URL to WordPress release notes, 1: WordPress version
 number, 2: Minimum required PHP version number, 3: Current PHP version
 number */
 $message = sprintf( __( 'You cannot update because <a
 href="%1$s">WordPress %2$s</a> requires PHP version %3$s or higher. You
 are running version %4$s.' ), $version_url, $update->current,
 $update->php_version, $php_version );
 }}}

 https://build.trac.wordpress.org/browser/trunk/wp-
 admin/upgrade.php?marks=93-94#L93

 {{{
 /* translators: 1: URL to WordPress release notes, 1: WordPress version
 number, 2: Minimum required PHP version number, 3: Current PHP version
 number */
 $message = sprintf( __( 'You cannot update because <a
 href="%1$s">WordPress %2$s</a> requires PHP version %3$s or higher. You
 are running version %4$s.' ), $version_url, $wp_version,
 $required_php_version, $php_version );
 }}}

 https://build.trac.wordpress.org/browser/trunk/wp-admin/update-
 core.php?marks=86-87#L86

 {{{
 /* translators: 1: WordPress version number, 2: Minimum required MySQL
 version number, 3: Current MySQL version number */
 $message = sprintf( __( 'You cannot update because <a
 href="%1$s">WordPress %2$s</a> requires MySQL version %3$s or higher. You
 are running version %4$s.' ), $version_url, $update->current,
 $update->mysql_version, $mysql_version );
 }}}


 https://build.trac.wordpress.org/browser/trunk/wp-
 admin/upgrade.php?marks=96-97#L96

 {{{
 /* translators: 1: WordPress version number, 2: Minimum required MySQL
 version number, 3: Current MySQL version number */
 $message = sprintf( __( 'You cannot update because <a
 href="%1$s">WordPress %2$s</a> requires MySQL version %3$s or higher. You
 are running version %4$s.' ), $version_url, $wp_version,
 $required_mysql_version, $mysql_version );
 }}}

--

Comment:

 Introduced in [44451]. /Cc @swissspidy

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46111#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform