[wp-trac] [WordPress Trac] #44044: $allowed_tags and $allowed_protocols in wp_privacy_generate_personal_data_export_group_html not filterable.
WordPress Trac
noreply at wordpress.org
Sun Jan 27 09:12:36 UTC 2019
#44044: $allowed_tags and $allowed_protocols in
wp_privacy_generate_personal_data_export_group_html not filterable.
-------------------------------------------------+-------------------------
Reporter: TZ Media | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: Future
| Release
Component: Privacy | Version: 4.9.6
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests needs- | Focuses:
refresh |
-------------------------------------------------+-------------------------
Changes (by garrett-eclipse):
* keywords: has-patch has-unit-tests commit => has-patch has-unit-tests
needs-refresh
Comment:
Thanks @birgire the patch applies cleanly and tests run successfully.
I wonder if we can remove the empty `$group_html` instantiation and just
create the variable on the following line here;[[BR]]
`$group_html = '<h2>' . esc_html( $group_data['group_label'] ) .
'</h2>';`
Aside from that things are looking good, just applying refresh as the unit
test versions will need to be updated when this gets milestoned.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/44044#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list