[wp-trac] [WordPress Trac] #44761: Privacy policy guide url is not escaped in Privacy Policy edit page
WordPress Trac
noreply at wordpress.org
Sun Jan 27 07:10:23 UTC 2019
#44761: Privacy policy guide url is not escaped in Privacy Policy edit page
-------------------------------------------------+-------------------------
Reporter: itowhid06 | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Future
| Release
Component: Privacy | Version: 4.9.6
Severity: normal | Resolution:
Keywords: has-patch needs-refresh dev- | Focuses: coding-
feedback | standards
-------------------------------------------------+-------------------------
Changes (by garrett-eclipse):
* keywords: has-patch commit => has-patch needs-refresh dev-feedback
* focuses: privacy => coding-standards
Comment:
Thanks for the report and initial patch @itowhid06. And @birgire I
appreciate the additional case.
Attempting to apply the patch currently fails for trunk. Along with a
refresh I'm wondering if we can move the translator comments within the
multiline printf statements.
I also feel the two instances of this translator comment could be made
more explicit by indicating it's for the Privacy Policy page. [[BR]]
`/* translators: 1: URL to edit page, 2: URL to preview page */` [[BR]]
I'm thinking; [[BR]]
`/* translators: 1: URL to edit Privacy Policy page, 2: URL to preview
Privacy Policy page */`
The translator comment changes can be handled in an additional ticket,
just wanted to flag while I was reviewing.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/44761#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list