[wp-trac] [WordPress Trac] #46098: Help notice displayed on Privacy Policy page missing in block editor

WordPress Trac noreply at wordpress.org
Sun Jan 27 06:52:30 UTC 2019

#46098: Help notice displayed on Privacy Policy page missing in block editor
 Reporter:  aduth                    |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Privacy                  |     Version:  5.0
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:  administration
Changes (by garrett-eclipse):

 * keywords:  has-patch => has-patch needs-refresh
 * focuses:   => administration
 * version:   => 5.0


 Thanks @aduth I appreciate you taking a look at this.

 The patch applies cleanly to trunk and introduces the notice to Gutenberg
 so that's a great start. Below, I provided some feedback for some issues
 and thoughts.

 The Gutenberg Notice itself;
 - At 960px wide the notice is displaced from the left. (screenshot)
 - On mobile there's a gap between the admin bar and the notice.
 - At various widths the dismiss close (x) overlaps the text. (screenshot)
 *These issues may apply in general to the notices module, as you wrote it
 I assume you'd know better than I ;)

 As the dismiss isn't persistent in that a reload will revive the notice we
 should remove the dismiss from this notice and address it along w/ the
 dismissal for the classic editor version in #44981.

 I noticed this patch removes support of the notice when Classic Editor is
 enabled. We should continue providing the notice on the classic editor
 interface until at least official support for the classic editor ends.

 Looking at the code, the switch to block editor notices also stripped the
 translator comment. This should be preserved, and if we have to implement
 two versions of the notice to reduce i18N we should stick with one string
 w/ translator comments. As the block editor notice supports the link
 string it should also get a unique translator comment and I suggest it be
 updated to 'View Privacy Policy Guide' to be explicit.

 Thanks for the patch, let me know if I can clarify anything.

Ticket URL: <https://core.trac.wordpress.org/ticket/46098#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list