[wp-trac] [WordPress Trac] #46112: Administration: Unnecessary use of plural handling in user.php
WordPress Trac
noreply at wordpress.org
Sat Jan 26 20:48:09 UTC 2019
#46112: Administration: Unnecessary use of plural handling in user.php
--------------------------+-----------------------------
Reporter: tobifjellner | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: General | Version:
Severity: normal | Keywords:
Focuses: |
--------------------------+-----------------------------
Here's a place in user.php where I don't understand why _n() (actually
even _nx() is used.
As long as you only show a number without any surrounding words that would
depend on this number, you don't need the hassle of _n().
https://build.trac.wordpress.org/browser/trunk/wp-
admin/includes/user.php?marks=1175#L1175
This is a new string for WordPress 5.1
{{{$views[ $status ] = '<a href="' . esc_url( add_query_arg(
'filter-status', $status, $admin_url ) ) . "\" $current_link_attributes>"
. sprintf( _nx( '%1$s <span class="count">(%2$d)</span>', '%1$s <span
class="count">(%2$d)</span>', $total_status_requests, 'requests' ),
esc_html( $label ), number_format_i18n( $total_status_requests ) ) .
'</a>';}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46112>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list