[wp-trac] [WordPress Trac] #43992: Prevent activation of a plugin if its required PHP version is too high
WordPress Trac
noreply at wordpress.org
Fri Jan 25 21:31:25 UTC 2019
#43992: Prevent activation of a plugin if its required PHP version is too high
-------------------------------------------------+-------------------------
Reporter: flixos90 | Owner: (none)
Type: task (blessed) | Status: new
Priority: normal | Milestone: 5.2
Component: Plugins | Version:
Severity: major | Resolution:
Keywords: needs-unit-tests servehappy dev- | Focuses:
feedback has-patch needs-testing |
-------------------------------------------------+-------------------------
Comment (by afragen):
Replying to [comment:16 joyously]:
> I only looked at the last diff, but it is adding unnecessary code for
reading the plugin file.
> The headers are added to `get_plugin_data`, which is already reading the
plugin file, so that function should be where the default value is
returned if needed.
>
I admit I'm a little confused. In what part of the diff are you referring
to and what do you think is unnecessary?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/43992#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list