[wp-trac] [WordPress Trac] #46093: User profile checkbox margin issue.

WordPress Trac noreply at wordpress.org
Fri Jan 25 09:11:22 UTC 2019

#46093: User profile checkbox margin issue.
 Reporter:  punit5658         |       Owner:  afercia
     Type:  defect (bug)      |      Status:  assigned
 Priority:  normal            |   Milestone:  5.2
Component:  Users             |     Version:  3.3
 Severity:  normal            |  Resolution:
 Keywords:  has-patch needs-  |     Focuses:  accessibility, administration
  refresh                     |
Changes (by afercia):

 * status:  new => assigned
 * focuses:  administration => accessibility, administration
 * owner:  (none) => afercia
 * version:  trunk => 3.3
 * milestone:  Awaiting Review => 5.2
 * keywords:  has-patch needs-testing => has-patch needs-refresh


 @punit5658 thanks for your report. This is an interesting case.

 As you've noticed, the markup is different. The "Show Toolbar when viewing
 site" checkbox is wrapped in a `<fieldset>` element (with a legend) even
 if it's only one checkbox. Instead, `<fieldset>` should only be used to
 group a set of related form controls together.

 Turns out a few years ago, when the toolbar was still called "Admin Bar",
 there were ''two'' checkboxes (see attached screenshot). Then, in [18700]
 this option was simplified to have only one checkbox. However, the
 fieldset and legend survived to that change.

 As there's now no reason to use a `<fieldset>` and a `<legend>`, I'd
 suggest to simply remove them instead of changing the CSS. This would also
 solve the margin issue in the mobile view.

Ticket URL: <https://core.trac.wordpress.org/ticket/46093#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list