[wp-trac] [WordPress Trac] #46099: Ignore theme based node_modules

[WordPress Trac]

#46099: Ignore theme based node_modules
---------------------------+-------------------------------------
 Reporter:  nielslange     |      Owner:  nielslange
     Type:  defect (bug)   |     Status:  assigned
 Priority:  normal         |  Milestone:  Awaiting Review
Component:  Bundled Theme  |    Version:  trunk
 Severity:  normal         |   Keywords:  has-patch needs-testing
  Focuses:                 |
---------------------------+-------------------------------------
 Recently, the Twenty Nineteen theme was moved from Github into Trac.
 Twenty Nineteen is the first theme that is using ''npm'' and therefore has
 a ''node_modules'' directory within the theme folder.

 When running `grunt`, `grunt build` or `grunt watch` multiple errors occur
 and the command gets aborted. While this could be bypassed using `grunt
 --force`, `grunt build --force` and `grunt watch --force`, a better
 approach would be to ignore the theme based ''node_module'' folder.

 **Steps to reproduce**

 1. Navigate to `/src/wp-content/themes/twentyninteen`
 2. Run `npm install`
 3. Navigate to `/`
 4. Run `grunt`

 **Expected result**

 - No error occurs.

 **Current result**

 - The following error occurs:

 {{{
 Running "jsvalidate:build" (jsvalidate) task
 ...
 ...
 ...
 Encountered 292 errors.
 Warning: Task "jsvalidate:build" failed. Use --force to continue.
 Aborted due to warnings.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46099>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform