[wp-trac] [WordPress Trac] #46097: WSOD protection: network paused plugin cannot be resumed from the non-network plugins screen

[WordPress Trac]

#46097: WSOD protection: network paused plugin cannot be resumed from the non-
network plugins screen
--------------------------+------------------------------
 Reporter:  pbiron        |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  General       |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+------------------------------
Description changed by pbiron:

Old description:

> As reported in ticket:46060#comment:3
>
>   if a network active plugin is paused and an admin goes to the plugins
> screen for one of the sites in the network (not the network plugins
> screen), the "Resume" link for the network paused plugin doesn't actually
> resume the plugin.  My guess is either the "resume" logic should check
> whether the paused plugin is network active or not and act accordingly,
> or that link should go to the network plugins screen to resume the
> plugin.
>
> And here's a little more //may// be related:
>
> * if the network active plugin is paused while visiting a non-network
> admin screen and whatever caused the fatal is fixed **before** visiting
> the network plugins screen, then the plugin is shown as `paused` (i.e.,
> has the peach background and the "Network Resume" link is there) but it
> does **not** have the `paused` status.  Hence, when you try to resume it
> (even from the network plugins screen it seems to still error.
> * note: the plugin I used to test this was one that defined a main plugin
> class and when trying to resume, it errors with a "can't redefine class
> XYZ_Plugin" message...so PHP still seems to have loaded the main class
> even tho it is paused.

New description:

 As reported in ticket:46060#comment:3

   if a network active plugin is paused and an admin goes to the plugins
 screen for one of the sites in the network (not the network plugins
 screen), the "Resume" link for the network paused plugin doesn't actually
 resume the plugin.  My guess is either the "resume" logic should check
 whether the paused plugin is network active or not and act accordingly, or
 that link should go to the network plugins screen to resume the plugin.

 And here's a little more info that //may// be related:

 * if the network active plugin is paused while visiting a non-network
 admin screen and whatever caused the fatal is fixed **before** visiting
 the network plugins screen, then the plugin is shown as `paused` (i.e.,
 has the peach background and the "Network Resume" link is there) but it
 does **not** have the `paused` status.  Hence, when you try to resume it
 (even from the network plugins screen it seems to still error.
 * note: the plugin I used to test this was one that defined a main plugin
 class and when trying to resume, it errors with a "can't redefine class
 XYZ_Plugin" message...so PHP still seems to have loaded the main class
 even tho it is paused.

--

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46097#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform