[wp-trac] [WordPress Trac] #46094: Update TinyMCE to 4.9.2

[WordPress Trac]

#46094: Update TinyMCE to 4.9.2
--------------------------------+-----------------------
 Reporter:  iseulde             |       Owner:  iseulde
     Type:  defect (bug)        |      Status:  assigned
 Priority:  normal              |   Milestone:  5.1
Component:  External Libraries  |     Version:
 Severity:  normal              |  Resolution:
 Keywords:  has-patch           |     Focuses:
--------------------------------+-----------------------

Comment (by iseulde):

 There are known failures when running the e2e test suite against core. Cc
 @gziolo. Here I'm trying to figure out if there are any failures
 introduced.

 Without patch

 Test Suites: 25 failed, 36 passed, 61 total
 Tests:       81 failed, 4 skipped, 174 passed, 259 total
 Snapshots:   1 failed, 117 passed, 118 total
 Time:        513.817s, estimated 940s
 Ran all test suites.


 With patch

 Test Suites: 26 failed, 35 passed, 61 total
 Tests:       83 failed, 4 skipped, 172 passed, 259 total
 Snapshots:   4 failed, 114 passed, 118 total
 Time:        530.14s
 Ran all test suites.

 So we have 1 additional failing test suite, 2 more failing tests and 3
 more failing snapshots.

 {{{
 undo › should undo typing after non input change
 }}}

 The failure here is expected. The non breaking space is replaced by a
 normal space.

 {{{
  FAIL  test/e2e/specs/blocks/list.test.js (24.127s)
   ● List › should split indented list item

     expect(value).toMatchSnapshot()

     Received value does not match stored snapshot "List should split
 indented list item 1".

     - Snapshot
     + Received

       "<!-- wp:list -->
     - <ul><li>one<ul><li>two</li><li>three</li></ul></li></ul>
     + <ul><li>one</li><li>two</li><li>three</li></ul>
       <!-- /wp:list -->"

       193 |             await page.keyboard.type( 'three' );
       194 |
     > 195 |             expect( await getEditedPostContent()
 ).toMatchSnapshot();
           |                                                    ^
       196 |     } );
       197 |
       198 |     it( 'should be immeadiately saved on indentation', async
 () => {

       at Object.toMatchSnapshot
 (test/e2e/specs/blocks/list.test.js:195:42)
       at tryCatch (node_modules/regenerator-runtime/runtime.js:62:40)
       at Generator.invoke [as _invoke] (node_modules/regenerator-
 runtime/runtime.js:288:22)
       at Generator.prototype.(anonymous function) [as next] (node_modules
 /regenerator-runtime/runtime.js:114:21)
       at asyncGeneratorStep (test/e2e/specs/blocks/list.test.js:9:103)
       at _next (test/e2e/specs/blocks/list.test.js:11:194)

   ● List › should be immeadiately saved on indentation

     expect(value).toMatchSnapshot()

     Received value does not match stored snapshot "List should be
 immeadiately saved on indentation 1".

     - Snapshot
     + Received

       "<!-- wp:list -->
     - <ul><li>one<ul><li></li></ul></li></ul>
     + <ul><li>one</li><li></li></ul>
       <!-- /wp:list -->"

       202 |             await pressWithModifier( 'primary', 'm' );
       203 |
     > 204 |             expect( await getEditedPostContent()
 ).toMatchSnapshot();
           |                                                    ^
       205 |     } );
       206 | } );
       207 |

       at Object.toMatchSnapshot
 (test/e2e/specs/blocks/list.test.js:204:42)
       at tryCatch (node_modules/regenerator-runtime/runtime.js:62:40)
       at Generator.invoke [as _invoke] (node_modules/regenerator-
 runtime/runtime.js:288:22)
       at Generator.prototype.(anonymous function) [as next] (node_modules
 /regenerator-runtime/runtime.js:114:21)
       at asyncGeneratorStep (test/e2e/specs/blocks/list.test.js:9:103)
       at _next (test/e2e/specs/blocks/list.test.js:11:194)

 }}}

 This one is unexpected.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46094#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform