[wp-trac] [WordPress Trac] #45944: Twenty Nineteen: Added URL in :after styles for print.css is unreliable

[WordPress Trac]

#45944: Twenty Nineteen: Added URL in :after styles for print.css is unreliable
---------------------------+-----------------------------
 Reporter:  kjellr         |       Owner:  (none)
     Type:  defect (bug)   |      Status:  new
 Priority:  low            |   Milestone:  Future Release
Component:  Bundled Theme  |     Version:  5.0.3
 Severity:  normal         |  Resolution:
 Keywords:  needs-testing  |     Focuses:
---------------------------+-----------------------------
Changes (by laurelfulford):

 * milestone:  Awaiting Review => Future Release


Comment:

 Thanks for moving this over, @kjellr!

 I did a bit of investigation because, honestly, this was totally bugging
 me!

 It looks like these styles are the culprit:

 {{{
 /* Remove image filters from featured image */
   .image-filters-enabled *:after {
     display: none !important;
 }
 }}}

 ... which explains why it was only working sometimes -- if the image
 filter wasn't enabled, that class wouldn't be present.

 I think this should be fixable by making the selector more specific
 (assuming the `!important` has to stay):

 {{{
 /* Remove image filters from featured image */
   .image-filters-enabled .site-featured-image *:after {
     display: none !important;
 }
 }}}

 ... but just let me know if I'm missing something here!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45944#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform