[wp-trac] [WordPress Trac] #46072: add a $metas param to wpmu_create_blog()
WordPress Trac
noreply at wordpress.org
Tue Jan 22 21:47:22 UTC 2019
#46072: add a $metas param to wpmu_create_blog()
--------------------------------+------------------------------
Reporter: pbiron | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Networks and Sites | Version: trunk
Severity: normal | Resolution:
Keywords: | Focuses: multisite
--------------------------------+------------------------------
Comment (by pbiron):
[[https://core.trac.wordpress.org/attachment/ticket/46072/46072.diff|46072.diff]]
is just a proof-of-concept, and is far from ready to be merged.
It sets things up correctly for the `wp_initialize_site` hook. But I
haven't yet investigated all of the other places in core, and/or all the
other hooks that are fired on blog creation, that might be affected by the
change. I will certainly do that, and update the patch accordingly, if
the general idea is accepted.
A few questions:
1. While it makes more sense "logically" to have the new param right after
the `$options` param, I've added it at the end of the param list, so that
existing code expecting the optional `$network_id` param in that place are
not affected. Do folks agree that is the right thing to do?
2. Should the new param be passed to the **deprecated** `wpmu_new_blog`
hook (in `wp_insert_site()`)? My sense is **no**, but I thought I'd ask.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46072#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list