[wp-trac] [WordPress Trac] #46071: TinyMCE Classic Block: fix "Advanced Link" modal
WordPress Trac
noreply at wordpress.org
Tue Jan 22 21:47:16 UTC 2019
#46071: TinyMCE Classic Block: fix "Advanced Link" modal
--------------------------+---------------------
Reporter: azaozz | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 5.1
Component: TinyMCE | Version: 5.0
Severity: normal | Resolution:
Keywords: | Focuses:
--------------------------+---------------------
Comment (by azaozz):
There are few reasons for these bugs. Most importantly the editor instance
is inline and some "utility" functions work a bit differently.
In 46071.diff:
- Refresh the `wpLink` modal and `wplink` editor plugin a bit.
- Always select the (newly inserted or existing) link node after the modal
has been opened. Passing it from the editor plugin breaks as the editor
content is reloaded on editor.blur(), and opening the modal and clicking
in it triggers that.
- Remove outdated editor.focus() on opening the modal (was bad for
accessibility).
Tested in Firefox, Chrome and Edge on Win10.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46071#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list