[wp-trac] [WordPress Trac] #45352: wp_targeted_link_rel filter can result in rel attribute with no value

[WordPress Trac]

#45352: wp_targeted_link_rel filter can result in rel attribute with no value
-------------------------------------------------+-------------------------
 Reporter:  spartank                             |       Owner:
                                                 |  SergeyBiryukov
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.1
Component:  Formatting                           |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  good-first-bug has-patch has-unit-   |     Focuses:
  tests                                          |
-------------------------------------------------+-------------------------

Comment (by peterwilsoncc):

 I'd rather take the approach that if a developer clears
 `wp_targeted_link_rel` they don't wish to use the feature.
 [attachment:"45352.3.diff"] returns early if that is the case.

 @spartank to answer your question about the test: filters (along with
 actions and a few other globals) are reset by the test suite automatically
 between tests so there is no need for the `remove_filter()` call.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45352#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform