[wp-trac] [WordPress Trac] #46044: Rename `wp_update_php_annotation()` to `wp_get_update_php_annotation()`

WordPress Trac noreply at wordpress.org
Sun Jan 20 16:28:38 UTC 2019


#46044: Rename `wp_update_php_annotation()` to `wp_get_update_php_annotation()`
-----------------------------------------------+---------------------
 Reporter:  afragen                            |       Owner:  (none)
     Type:  defect (bug)                       |      Status:  new
 Priority:  normal                             |   Milestone:  5.2
Component:  Plugins                            |     Version:  trunk
 Severity:  normal                             |  Resolution:
 Keywords:  has-patch servehappy dev-feedback  |     Focuses:
-----------------------------------------------+---------------------

Comment (by afragen):

 Replying to [comment:2 flixos90]:
 > That makes sense. However, I would suggest introducing a new
 `wp_get_update_php_annotation()` and keeping `wp_update_php_annotation()`
 as is. Many core functions have a variant that gets the output and another
 one that directly outputs it. `wp_update_php_annotation()` could just call
 `echo wp_get_update_php_annotation()`.
 >
 > This way we don't need to modify all the existing function calls, and we
 keep this a separate change (since it's only required for our 5.2 work,
 not anything scheduled for 5.1).

 I’ll have an updated patch soon. Thanks for the feedback.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46044#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list