[wp-trac] [WordPress Trac] #46045: Sandboxed live editing of PHP files doesn't work together with WSOD protection
WordPress Trac
noreply at wordpress.org
Sun Jan 20 13:55:38 UTC 2019
#46045: Sandboxed live editing of PHP files doesn't work together with WSOD
protection
----------------------------+---------------------
Reporter: ocean90 | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 5.1
Component: Bootstrap/Load | Version: trunk
Severity: normal | Resolution:
Keywords: needs-patch | Focuses:
----------------------------+---------------------
Description changed by ocean90:
Old description:
> To reproduce:
>
> * Open the plugin editor
> * Select an active plugin
> * Do a change which will cause a fatal error
> * Click "Update File"
> * You should now get the `loopback_request_failed` message (Unable to
> communicate back with site…)
> * Go to wp-admin/plugins.php and notice that the plugin has been paused
> which means the changes were actually saved.
New description:
To reproduce:
* Open the plugin editor
* Select an active plugin
* Do a change which will cause a fatal error
* Click "Update File"
* You should now get the `loopback_request_failed` message (Unable to
communicate back with site…)
* Go to wp-admin/plugins.php and notice that the plugin has been paused
~~which means the changes were actually saved~~ because the WSOD
protection did kick in even the changes were rolled back by
`wp_edit_theme_plugin_file()`.
--
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46045#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list