[wp-trac] [WordPress Trac] #45700: Twenty Seventeen: Remove unused third-party resources from README.txt
WordPress Trac
noreply at wordpress.org
Fri Jan 18 20:24:52 UTC 2019
#45700: Twenty Seventeen: Remove unused third-party resources from README.txt
---------------------------+----------------------
Reporter: mukesh27 | Owner: (none)
Type: defect (bug) | Status: closed
Priority: normal | Milestone:
Component: Bundled Theme | Version:
Severity: normal | Resolution: invalid
Keywords: has-patch | Focuses:
---------------------------+----------------------
Changes (by laurelfulford):
* status: new => closed
* resolution: => invalid
* milestone: Awaiting Review =>
Comment:
Thanks for the report and patch @mukesh27!
I took a look, and as far as I can tell both of these resources are still
being used in the theme.
Even though the font itself isn't used, the SVG icons in Twenty Seventeen
come from Font Awesome -- there's some discussion around that here:
https://github.com/WordPress/twentyseventeen/issues/60
ScrollTo also still looks like it's being used -- it's enqueued in
functions.php, and the function `scrollTo()` shows up in both global.js
and customize-preview.js.
I'm going to close this issue, but please let me know if you have any
questions! Also thank you for raising this. It's always good to make sure
the readme matches what's in the theme, and in this case it wasn't super-
clear -- I had to do some digging to actually make sure these were both
being used!
--
Ticket URL: <https://core.trac.wordpress.org/ticket/45700#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list