[wp-trac] [WordPress Trac] #42598: Twenty Seventeen: Sticky header offset issue

WordPress Trac noreply at wordpress.org
Fri Jan 18 20:09:43 UTC 2019

#42598: Twenty Seventeen: Sticky header offset issue
 Reporter:  anevins                  |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  5.1
Component:  Bundled Theme            |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  javascript

Comment (by laurelfulford):

 Thanks for reporting this issue, @anevins, and for the patch,

 When testing in Firefox (64.0.2, OS 10.14), the patch works exactly as
 described for non-logged in users - when I follow a Continue Reading link,
 it sets the scroll position so the navigation isn't covering the text I
 would be reading next.

 But when I test when logged in, the link initially goes to the scroll
 position it should, then offsets it.

 I've created a couple quick screen captures to show what I mean -- the
 first line of the paragraph where the link should go is bolded and red, to
 make it easier to spot. I increased the timeout in the JavaScript, so it's
 easier to see where the link first goes, but I was getting the same effect
 at regular speed, too:

 Not logged in: https://cloudup.com/iDM59YBpLGs

 Logged in: https://cloudup.com/iN4RO_HtF9K

 In Chrome (71, OS 10.14), the logged in and non-logged in behaviour both
 work consistently. The only issue I ran into is that the offset is a bit
 off when you're logged in, so the first line of the paragraph you should
 be going to is covered by the menu. I'm betting this is because the admin
 toolbar height needs to be included in the offset.

 @jasonlcrane would you be able to take another crack at this? Thanks!

Ticket URL: <https://core.trac.wordpress.org/ticket/42598#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list