[wp-trac] [WordPress Trac] #42321: Menu title field does not clear invalid class

[WordPress Trac]

#42321: Menu title field does not clear invalid class
---------------------------------------------+-----------------------------
 Reporter:  ritukaushal5693                  |       Owner:  welcher
     Type:  defect (bug)                     |      Status:  assigned
 Priority:  normal                           |   Milestone:  5.1
Component:  Menus                            |     Version:  4.8.2
 Severity:  normal                           |  Resolution:
 Keywords:  good-first-bug has-patch commit  |     Focuses:  ui,
                                             |  administration
---------------------------------------------+-----------------------------
Changes (by afercia):

 * keywords:  good-first-bug has-patch needs-refresh => good-first-bug has-
     patch commit


Comment:

 [attachment:"42321.diff"] addresses the points above.
 Also, I'd propose to keep using the `form-invalid` CSS class, as the new
 one on the single input doesn't account for the focus style: when invalid
 and focused, two box-shadows (red and blue) were applied to the field. We
 shouldn't change this part as it would require some unnecessary CSS
 refactoring. As far as I can tell, there are no concerns for unintended
 side effects as `form-invalid` is only applied to the menu name field
 parent.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42321#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform