[wp-trac] [WordPress Trac] #42321: Menu title field does not clear invalid class
WordPress Trac
noreply at wordpress.org
Fri Jan 18 08:04:23 UTC 2019
#42321: Menu title field does not clear invalid class
-------------------------------------------------+-------------------------
Reporter: ritukaushal5693 | Owner: welcher
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 5.1
Component: Menus | Version: 4.8.2
Severity: normal | Resolution:
Keywords: good-first-bug has-patch needs- | Focuses: ui,
refresh | administration
-------------------------------------------------+-------------------------
Changes (by afercia):
* keywords: good-first-bug has-patch commit => good-first-bug has-patch
needs-refresh
Comment:
The patch should use the `input` event and not `keyup`:
- `keyup` was generally used only to cover IE 8
- `input` accounts also when pasting with the mouse
- the menu name doesn't have a title attribute any longer so checking for
`menuName.attr('title')` should be removed?
- misses some coding standards (mainly: spaces)
--
Ticket URL: <https://core.trac.wordpress.org/ticket/42321#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list