[wp-trac] [WordPress Trac] #18857: get_plugin_page_hookname uses menu_title to construct subpage load-hooks

[WordPress Trac]

#18857: get_plugin_page_hookname uses menu_title to construct subpage load-hooks
--------------------------------------------+-----------------------------
 Reporter:  apocalip                        |       Owner:  chriscct7
     Type:  defect (bug)                    |      Status:  assigned
 Priority:  normal                          |   Milestone:  5.2
Component:  Plugins                         |     Version:  3.1.4
 Severity:  normal                          |  Resolution:
 Keywords:  has-patch has-unit-tests early  |     Focuses:  administration
--------------------------------------------+-----------------------------

Comment (by chriscct7):

 I went to go punt this and noticed Pento beat me to it.

 As an update I took a lot of time on this with one of our company
 developers and we thought through a lot of the edge cases.

 Unfortunately, from having done a lot of hours of testing and research, I
 don't think this is going to be possible to fix moving forward without
 backwards compatibility breaks. I would suggest those breaks still be
 made, but that this goes in first thing into 5.2, and it be announced to
 plugin developers straightaway so they have the entire cycle to make a
 very quick addition. Sadly while this would have been very easy to address
 & fix 7 years ago, doing so now is no longer as straightforward.

 I will put together a summary of the research tomorrow but basically the
 issue comes down to the fact that the best practice of allowing
 translations for menus has lead to a situation that it will be impossible
 to fix perfectly (either core will need to break BC, which I would
 suggest, or we will have to build a new option that new plugins can opt
 into to fix it moving forward, which I wouldn't recommend since all
 plugins using add_menu_page would also have to know to use it moving
 forward which is definitely not dev friendly).

 I will outline everything we looked into, the scope of possible changes we
 could do, and so forth as soon as possible.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/18857#comment:36>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform