[wp-trac] [WordPress Trac] #40590: wp_video_shortcode always adds controls="controls"

[WordPress Trac]

#40590: wp_video_shortcode always adds controls="controls"
-------------------------------------------------+-------------------------
 Reporter:  paulschreiber                        |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  Media                                |     Version:  4.7.4
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests needs-      |     Focuses:
  testing                                        |
-------------------------------------------------+-------------------------
Changes (by desrosj):

 * keywords:  has-patch 2nd-opinion has-unit-tests => has-patch has-unit-
     tests needs-testing
 * milestone:  5.1 => Future Release


Comment:

 This was discussed in today's Media chat. Here is a summary:

 - This is a reasonable change to the video shortcode, even though
 shortcodes have been unofficially replaced by blocks.
 - Adding the attribute is the preferred path forward (not adding a
 function argument).
 - The default for the attribute should definitely remain `true` to
 maintain the current default behavior.
 - This still needs more testing. @birgire's comment above makes it seem
 like this is an incomplete solution.

 All this considered, let's move this to Future Release until it has a more
 solid patch everyone is confident in.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/40590#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform