[wp-trac] [WordPress Trac] #43151: Media widgets shouldn't use a clickable div as an UI control

[WordPress Trac]

#43151: Media widgets shouldn't use a clickable div as an UI control
-------------------------------------+-------------------------------------
 Reporter:  afercia                  |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  5.2
Component:  Widgets                  |     Version:  4.8
 Severity:  normal                   |  Resolution:
 Keywords:  has-screenshots needs-   |     Focuses:  ui, accessibility,
  testing has-patch                  |  javascript
-------------------------------------+-------------------------------------

Comment (by afercia):

 [attachment:"43151.2.diff"]
 - updates the CSS class name
 - adds the focus style
 - removes a couple `<label>` elements used for buttons: buttons don't need
 to be associated to labels

 It would be great to address also the case of the Header image: it still
 uses a placeholder "div" that looks like a clickable thingy. It should be
 a "Add header image" button, while the other buttons should appear only
 when there's an image. I guess it can be addressed separately. /Cc
 @welcher

 [[Image(http://cldup.com/Bv5CsywIYK.png)]]

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43151#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform