[wp-trac] [WordPress Trac] #44563: WordPress 4.9.7 Media delete changes break plugins deleting media via stream wrappers

[WordPress Trac]

#44563: WordPress 4.9.7 Media delete changes break plugins deleting media via
stream wrappers
-------------------------------------------------+-------------------------
 Reporter:  antonypuckey                         |       Owner:  joemcgill
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.1
Component:  Media                                |     Version:  4.9.7
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing needs-unit-  |     Focuses:
  tests                                          |
-------------------------------------------------+-------------------------
Changes (by desrosj):

 * keywords:  has-patch needs-testing => has-patch needs-testing needs-unit-
     tests


Comment:

 At a minimum, the
 [https://core.trac.wordpress.org/browser/trunk/tests/phpunit/tests/functions.php?rev=44573#L96
 tests for `path_is_absolute()`] should be updated to account for stream
 URLs. Additional tests would be great. Streams have been problematic
 lately.

 At a minimum as far as testing is concerned, I'd like to know that the
 issue is solved in the [https://github.com/humanmade/S3-Uploads S3 Uploads
 plugin] with the suggested approach.

 @joemcgill I think this is a 5.2 or Future Release candidate, but did not
 want to punt it without your input.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44563#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform