[wp-trac] [WordPress Trac] #46014: The 'Mine' filter on single-post comments should be filtered using $post_id

WordPress Trac noreply at wordpress.org
Wed Jan 16 19:12:39 UTC 2019


#46014: The 'Mine' filter on single-post comments should be filtered using $post_id
-----------------------------+-----------------------------
 Reporter:  garrett-eclipse  |      Owner:  (none)
     Type:  defect (bug)     |     Status:  new
 Priority:  normal           |  Milestone:  Awaiting Review
Component:  Comments         |    Version:  trunk
 Severity:  major            |   Keywords:  needs-patch
  Focuses:  administration   |
-----------------------------+-----------------------------
 As @matt flagged here -
 https://wordpress.slack.com/archives/C02RQBWTW/p1547663425204000

 The comment count beside the 'Mine' filter is incorrect when on the
 single-post view (i.e. edit-comments.php?p=####&comment_status=approved)
 as it doens't account for the $post_id from the view.

 This was introduced to trunk in ticket #42379

 If `$post_id` is set in the `get_views` function then it should be used to
 create the mine count when calling `get_comments` here; [[BR]]
 https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-
 wp-comments-list-table.php?rev=42684#L280

 This can be fixed by passing `$post_id` as an arg to the `get_comments`
 call.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46014>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list