[wp-trac] [WordPress Trac] #45986: Update the update-php URL and add annotation

WordPress Trac noreply at wordpress.org
Wed Jan 16 16:58:56 UTC 2019


#45986: Update the update-php URL and add annotation
----------------------------------+------------------------
 Reporter:  afragen               |       Owner:  flixos90
     Type:  defect (bug)          |      Status:  reviewing
 Priority:  normal                |   Milestone:  5.1
Component:  Plugins               |     Version:  trunk
 Severity:  normal                |  Resolution:
 Keywords:  has-patch servehappy  |     Focuses:
----------------------------------+------------------------
Changes (by flixos90):

 * keywords:  has-patch servehappy dev-feedback => has-patch servehappy


Comment:

 [attachment:"45986.5.diff"] enhances the previous patches in the following
 ways:

 * Only show the information about updating PHP if `current_user_can(
 'update_php' )`. This was missed in the original ticket.
 * In `wp-admin/includes/plugin-install.php`, ensure that calling
 `wp_update_php_annotation()` does not cause invalid HTML markup with
 nested `p` tags.
 * In `wp-admin/includes/plugin-install.php`, get rid of the "so
 unfortunately you cannot install it" part of the message. This makes it
 consistent with the message about the WordPress version and prevents
 inaccuracies, as this information may also be displayed when the plugin is
 already installed.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45986#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list